dataclass-wizard icon indicating copy to clipboard operation
dataclass-wizard copied to clipboard

Fix: LiteralParser __contains__ method compares value of item with Literal arguments

Open mikeweltevrede opened this issue 1 year ago • 4 comments

Closes #67.

Instead of checking that type(item) is self.base_type (like is implemented in the base class AbstractParser), we need to check if the item is in the values of the given Literal.

mikeweltevrede avatar Feb 21 '24 14:02 mikeweltevrede

Would be nice to see this fix merged :)

rmmr avatar Mar 06 '24 13:03 rmmr

@rmmr I was planning to post a reminder today, great minds think alike :')

mikeweltevrede avatar Mar 06 '24 13:03 mikeweltevrede

@rnag Would you have time to look at this PR? Thanks!

mikeweltevrede avatar Mar 06 '24 13:03 mikeweltevrede

@rnag Hello :) Have you been able to consider this? Thanks :)

mikeweltevrede avatar May 01 '24 12:05 mikeweltevrede