valr icon indicating copy to clipboard operation
valr copied to clipboard

Published 20 hours ago • verified publisher icon rnabioco

update intervaltree

Open kriemo opened this issue 2 years ago • 1 comments

passes tests and checks but want to run through valgrind and ASAN/UBSAN before merging.

closes #349

kriemo avatar Aug 20 '22 20:08 kriemo

I wasn't able to set up ubsan/asan testing due to challenges getting dependencies installed. valgrind however reported no issues so I believe this should be ready to go. Performance is slightly slower with the updated interval tree.

kriemo avatar Aug 24 '22 23:08 kriemo

This looks good. I think the small drop in performance is a good trade off for increased maintainability.

We should be more explicit about acknowledging the IntervalTree code from ekg, probably in the comments of IntervalTree_ext.h

jayhesselberth avatar Oct 05 '22 12:10 jayhesselberth