rmwc icon indicating copy to clipboard operation
rmwc copied to clipboard
verified publisher icon rmwc

fix(Select): forward ref to enhanced menu

Open nicholaschiang opened this issue 5 years ago • 1 comments

Properly forwards the ref property to the underlying Menu component if passed in the enhanced prop to a Select.

nicholaschiang avatar Feb 27 '21 21:02 nicholaschiang

@jamesmfriedman Love to get your approval on this! Need it to be able to capture clicks (i.e. and not close a dialog if a menu that has rendered to portal is clicked that is within that dialog).

nicholaschiang avatar Feb 27 '21 21:02 nicholaschiang

@nicholaschiang we are sorry for the delay. Are these changes still relevant? Can you update the branch with the latest commits? We promise to act quick after that.

b-d-m-p avatar Mar 31 '23 23:03 b-d-m-p

@jensborch @EmiBemi @thaestrup This looks alright to me. I think it solves an issue we were having on our project. I can resolve the conflicts, but do you think this is good to merge?

b-d-m-p avatar Apr 27 '23 00:04 b-d-m-p

@b-d-m-p It would be nice if you could solve the merge errors. I will create a task on our Kanban board for this

jensborch avatar May 02 '23 10:05 jensborch

Merged the conflicts locally but can't push to this branch because it is a fork that I don't have permission on, so made a new MR here: https://github.com/rmwc/rmwc/pull/932

Closing this one.

b-d-m-p avatar May 02 '23 11:05 b-d-m-p