Robin Munn

Results 288 comments of Robin Munn

I've created https://github.com/actions/toolkit/pull/1723, which is essentially this PR plus passing the `mode` property into `zip.append`.

https://github.com/actions/upload-artifact/issues/485 looks relevant here, and could be easily fixed in the same PR by using `archive.file` instead of `archive.append`.

Commit 5f62f1e65ba5d59c8c7ec0bb0387358c8d905263 should fix https://github.com/actions/upload-artifact/issues/485.

@bethanyj28 - It looks like you've been doing recent work on the `packages/artifact` code that this touches. Would you like to give this PR a review? It's intended to fix...

@SrRyan @yacaovsnc You recently reviewed PRs touching this part of the code (#1678 and #1724 respectively). Could you take a look at this PR? It's intended to fix [the seventh-most-upvoted...

@bdehamer - Can you tell me who is the right person to review PRs in this repo? I've asked multiple GitHub team members so far, with no response yet from...

@konradpabjan - Your [GitHub profile](https://github.com/konradpabjan) says you're working on GitHub Actions, and you created [one of the bugs this PR is supposed to fix](https://github.com/actions/upload-artifact/issues/485). Could you let me know how...

@joshmgross - Could I ask you to take a look at this PR? It's intended to fix [the sixth-most-upvoted issue in actions/upload-artifact](https://github.com/actions/upload-artifact/issues/38) and also [a recent issue that prevents uploaded...

Thanks for responding. This PR was originally based around supporting file permissions, which is a feature request that's more than four years old at this point (https://github.com/actions/upload-artifact/issues/38, https://github.com/actions/download-artifact/issues/14). I then...

@joshmgross - I've created https://github.com/actions/toolkit/pull/1771 for the EMFILE fix without the zip file permissions bugfix.