Robert Muir
Robert Muir
what are all these commits just adding more public classes for no reason?: TermVectors, now DocTermVectors -1: Full stop.
As a library, we should throw the correct exception type, we shouldn't change it for fun. It is not correct to assume that this can only happen as result of...
I'm still -1 for the change. If you hit `StackOverFlowError`, really you should let the VM exit. There are no guarantees at this point. I don't care what OpenJDK does...
This file is automatically generated from https://github.com/snowballstem/snowball-website Can you suggest a PR to them? We can then update snowball over here afterwards. The file in question is https://github.com/snowballstem/snowball-website/blob/master/algorithms/spanish/stop.txt
@zhaih please take it!
why does this need to do anything more than `getFilePointer()` on `close()` or something to capture how much was written?
I don't know what this string interning is here, but I am strongly opposed to it
It does essentially the same thing. Leaking memory on purpose into static finals.
it absolutely is. Look at the fucking diff dude. You won't sneak this one past me. -1 to this interning stuff. I remember what things were like when we made...
both are an issue. The threadlocal will leak badly, especially for cases that "churn" lots of threads (e.g. jetty defaults, e.g. java webapps). It will cause more harm than good....