cukedoctor icon indicating copy to clipboard operation
cukedoctor copied to clipboard

Maven Configuration Option dataUri not working

Open gerome-avec-un-g opened this issue 3 years ago • 5 comments

Hello,

It seems that the option to embbed images as data uri in HTML documents does not work. In fact it doesn't seem to exist at all in \com\github\cukedoctor\cukedoctor-maven-plugin\3.5.2\cukedoctor-maven-plugin-3.5.2.jar!\META-INF\maven\plugin.xml

The following Maven configuration is shown in error in my IDE :

com.github.cukedoctor cukedoctor-maven-plugin 3.5.2 documents html left true true true true true execute verify

Thanks

gerome-avec-un-g avatar Apr 20 '21 13:04 gerome-avec-un-g

Sorry, the code as been edited out... <plugin> <groupId>com.github.cukedoctor</groupId> <artifactId>cukedoctor-maven-plugin</artifactId> <version>3.5.2</version> <configuration> <outputDir>documents</outputDir> <format>html</format> <toc>left</toc> <numbered>true</numbered> <hideScenarioKeyword>true</hideScenarioKeyword> <hideStepTime>true</hideStepTime> <hideSummarySection>true</hideSummarySection> <dataUri>true</dataUri> </configuration> <executions> <execution> <goals> <goal>execute</goal> </goals> <phase>verify</phase> </execution> </executions> </plugin>

gerome-avec-un-g avatar Apr 20 '21 13:04 gerome-avec-un-g

Hi. Thanks for reporting this. The dataUri feature has not yet been released. It was merged to the mainline a week ago but the latest release (3.5.2) was two months than ago.

@rmpestano, when do you plan on pushing a new release, please?

andrewesweet avatar Apr 20 '21 13:04 andrewesweet

Hey guys, I'll release 3.6.0 today and let you know here when it's synced into central.

rmpestano avatar Apr 20 '21 14:04 rmpestano

3.6.0 should be on maven central now, let me know if it works for you

rmpestano avatar Apr 21 '21 07:04 rmpestano

Hi,

3.6.0 fixes the issue with Maven, the dataUri option is available.

I still have an usage issue : where should I put my images in a standard Maven projet ?

I've tried the following : src/test/resources/features/businessdomain +---BusinessDomainFunctionality.feature +---image.jpg

with image::image.jpg[]

and only <img src="data:image/jpg;base64," alt="frais de garde pdf"> has been generated in the html code.

Thanks for your answers.

gerome-avec-un-g avatar Apr 21 '21 08:04 gerome-avec-un-g