DashMachine
DashMachine copied to clipboard
rmountjoy92
[WIP] Card alignment
This implements a 'layout' setting, which allows the user to left- right- or centeralign the cards.
This was asked for in #51
Todo: Fix to many cards overflowing the screen when using center
see https://github.com/rmountjoy92/DashMachine/pull/127#issuecomment-616513685
I see why you dont want to have smaller (or bigger) cards, but why is the alignment of the cards a problem? Generally if they move to the right side or the center should not affect the content of the cards as they are unaffected by the alignment on the mainpage
Whoops, sorry about that, I lumped these two together. I'll see if I can get this change looking good on 0.6 :+1:
@rmountjoy92 Quick question: i have experimented with coloured cards, is that something i should create a pr for or is that something that is already done or not wanted?
@rmountjoy92 Quick question: i have experimented with coloured cards, is that something i should create a pr for or is that something that is already done or not wanted?
I think that's a great idea! You should definitely use the css variables/classes in this file: https://github.com/rmountjoy92/DashMachine/blob/master/dashmachine/static/css/global/dashmachine-theme.css So you can access the theme colors. (feel free to add more variables/classes that you need)
this is also a good idea, but actually i thought of card-scoped colors, so that you can make nextcloud the color of your instance, and github a deeper black, and your mailclient green, you get the idea ^^
by the way, do you have a remote repo where you merge the stuf, or how does your workflow work? You seem to only close pr's but not actually merge them :D
So, here's how I've been doing it (working on putting this in the docs):
Master is stable branch, it is only changed when a major version from the develop branch is merged into it.
Right now I'm working on 0.6 (the next major version) and most of the changes are local on my computer (keep forgetting to push). If a pr is put on the develop branch, most of time I'll just merge it in (sometimes I see what pr is trying to accomplish, and just do it myself). If it's made on the master branch I've just been making the changes on my copy and closing the pr.