graphql-ruby
graphql-ruby copied to clipboard
rmosolgo
Ruby implementation of GraphQL
Looking through it now, it seems like I could do better on this: https://github.com/rmosolgo/graphql-ruby/blob/02dd62bcad658a044bb705493cb095778ec89cfc/lib/graphql/static_validation/literal_validator.rb#L71-L76 https://github.com/rmosolgo/graphql-ruby/blob/02dd62bcad658a044bb705493cb095778ec89cfc/lib/graphql/static_validation/rules/required_input_object_attributes_are_present.rb#L37-L44 Could those be DRY'd? Maybe this is part of the larger review of input validation...
**Describe the bug** When using AsyncDataloader instead of the normal one, operations that involve a Source will freeze and the HTTP request never completes. **Versions** `graphql` version: 2.2.4 `rails` (or...
**Describe the bug** According to the [GraphQL spec](http://spec.graphql.org/October2021/#sec-Objects.Type-Validation): > An Object type must define one or more fields. However, the GraphQL gem appears to treat object types that have no...
**Describe the bug** [FieldsWillMerge.find_conflict](https://github.com/rmosolgo/graphql-ruby/blob/master/lib/graphql/static_validation/rules/fields_will_merge.rb#L213-L247) omits the [type parity check](https://github.com/graphql/graphql-js/blob/main/src/validation/rules/OverlappingFieldsCanBeMergedRule.ts#L620-L631) implemented by `graphql-js`. This deviates the GraphQL Ruby implementation from spec compliance. Unfortunately, fixing this issue is a breaking change because...
**Describe the bug** The `fields_have_appropriate_selections` validation presently allows the following selection: ```graphql query { myUnion } ``` With `myUnion` being a union type, this query returns the following payload: ```json...
While reviewing some error handling code, I came across some code that appears unused. Perhaps I am missing something? https://github.com/rmosolgo/graphql-ruby/blob/f72c7a18e9c0f676fdf1087c3d5208b90752e1be/lib/graphql/static_validation/error.rb#L6-L14
Unable to find subscription with identifier: {"channel":"GraphqlChannel","channelId":"18bccb1dbd6"}
**Describe the bug** This is possibly not a bug in `graphql-ruby`, and I apologize in advance if that's the case, but I've just run out of ideas on what this...
**Describe the bug** When a dataloader is used, the order of fields in the response is affected. All the fields using dataloaders are delivered after the others fields. According to...
In this case, the fields aren't resolved and `@defer` doesn't set aside any work for later: ```graphql { things { ... ThingFields } } fragment ThingFields on Thing { ......
**Describe the bug** In case of exceptions raised by input types, query complexity is calculated wrong, causing misleading error responses. **Versions** `graphql` version: 2.1.3 `rails` (or other framework): 7.0.8 **GraphQL...
