Rich Loveland

Results 24 comments of Rich Loveland

Thanks for this thoughtful feedback. Sorry about my late response. I agree with you 100% - this is a pretty hacky approach. I'm not sure when/if I will be able...

Luckily `git clone --depth 1` works.

Hi folks, I added each of you to review for the following reasons/areas, but please feel free to comment on anything you see that is missing/incorrect/etc as well: - @jbowens...

> A few minor edit suggestions -- notably a few more places I think we should mention that feature is in `PREVIEW` Updated in the places where you mentioned. Do...

> Yeah, I think it makes sense to document those first three metrics: > > ``` > storage.wal.failover.primary.duration > storage.wal.failover.secondary.duration > storage.wal.failover.switch.count > ``` > > The `storage.wal.failover.secondary.duration` is probably...

@mwang1026 I went ahead and added WAL failover to the list of preview features since AFAICT we do that for everything else in Preview Let me know if you're good...

@florence-crl this is RFAL from a docs POV now in terms of sequencing, this should go in first, then #18548

@florence-crl thanks for the helpful review. I've incorporated everything from your first pass AFAICT - PTAL!

FWIW I don't think you have to care about this Jordan. Just filing to capture. I think patches to fix this will be relatively straightforward, and can be written by...

Probably too late to be useful now, but it was [this docs PR](https://github.com/cockroachdb/docs/pull/3669). I ended up asking Lauren to squash so I could do the review with `re` (which worked...