Roberta Miccoli

Results 64 comments of Roberta Miccoli

If you use the _student profile_, you should get those attributes (I took a look at https://services.renater.fr/federation/en/outils/outils-de-test/idp-de-test).

Yes, actually I can see them also by authenticating with the _authorized reader profile_ credentials. The fact that you see the username mapped on eduPersonPrincipalName is due to an IAM...

As a first approach we thought of adding in the subject (hardcoded) `[ IAM] ...`, e.g. `[atlas IAM]`

Perhaps we can put an if statement in the email template (adminHandleRequest.ftl) so that notes are only shown if the content is not empty. e.g. ``` Notes: ${notes} ```

Note that recently this check https://github.com/Sae126V/iam/blob/issue-759-registration-ui/iam-login-service/src/main/java/it/infn/mw/iam/registration/RegistrationRequestDto.java#L97 has been added for the Notes field and I saw it is already merged in this PR. I think this check should be removed...

> ## [![Quality Gate Failed](https://camo.githubusercontent.com/5333b8e2ff49bd5efdc6d2efd30ec08d7ac8d67c5e80190d03b6c2cb29a5de8b/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f5175616c6974794761746542616467652f71672d6661696c65642d323070782e706e67)](https://sonarcloud.io/dashboard?id=indigo-iam_iam&pullRequest=719) **Quality Gate failed** > > Failed conditions ![](https://camo.githubusercontent.com/ee78c91cde137cf4668f72b8e1247dadaaeb117c99c74bed0f21b1681b517491/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f6661696c65642d313670782e706e67) [76.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=indigo-iam_iam&pullRequest=719&metric=new_coverage&view=list) (required ≥ 85%) > > [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=indigo-iam_iam&pullRequest=719) Try to...

In the `resetPassword` method of the `DefaultPasswordResetService` service, it's better to move the event publication at the end, after changing the password and saving the account.

> In the `resetPassword` method of the `DefaultPasswordResetService` service, it's better to move the event publication at the end, after changing the password and saving the account. Done by @SteDev2...

> ## [![Quality Gate Passed](https://camo.githubusercontent.com/5889b9ad78888934928f8f18bb6431c836cd7cabe6c3a6a60a1a01434d67cfdb/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f5175616c6974794761746542616467652f71672d7061737365642d323070782e706e67)](https://sonarcloud.io/dashboard?id=indigo-iam_iam&pullRequest=719) **Quality Gate passed** > > Issues ![](https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [0 New issues](https://sonarcloud.io/project/issues?id=indigo-iam_iam&pullRequest=719&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) ![](https://camo.githubusercontent.com/6e7f22e3d7f9764d9cfb28e3b8ee5ebb5f711c5bb2dcec8a6db6b0d958d63134/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f61636365707465642d313670782e706e67) [1 Accepted issue](https://sonarcloud.io/project/issues?id=indigo-iam_iam&pullRequest=719&issueStatuses=ACCEPTED) > > Measures ![](https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=indigo-iam_iam&pullRequest=719&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) ![](https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [100.0% Coverage on...