testrmd icon indicating copy to clipboard operation
testrmd copied to clipboard

Is there still a need to install hadley/testthat#594 or can testthat 1.0.2 be used.

Open FvD opened this issue 8 years ago • 1 comments

Is this still true:

testthat (must use devtools::install_github("hadley/testthat#594") for now)

It seems to run fine with the current version of CRAN testthat 1.0.2, but I have not tried all expect_* so perhaps I'm setting myself up to run into trouble soon.

Do you know of any limitations when using testthat 1.0.2 works with testrmd? Or can you share the previously known issues so that I can check if they still cause trouble?

FvD avatar Sep 02 '17 00:09 FvD

Well, that is good to hear.

I don't see https://github.com/hadley/testthat/pull/594 or https://github.com/hadley/testthat/pull/597 having been merged though, so I can't vouch for testthat. I do know that an issue was that if you tried to use testthat as the compliance engine in testrmd it would not catch things properly.

Hope that helps.

rmflight avatar Sep 02 '17 01:09 rmflight