Ray Mattingly
Ray Mattingly
Oh yeah, good point. I bet we would. I can look into a fix there too
Actually, there's no realistic problem with write size. At least, no more than read size. Both make very naive lowball estimates based on the number of reads/writes: https://github.com/apache/hbase/blob/1ffa127be8abf2b4ab0be1a6ebb148a539e7a73f/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java#L191-L203 It's theoretically...
I pushed an addition which ensures we don't block requests indefinitely for read, write, or request size estimates
I believe these build failures are just noise, and will be fixed by a change that I've added to another PR: https://github.com/apache/hbase/pull/6018#discussion_r1650183058
Did your test also involve moving the backup location? For example, moving the backup from an S3 bucket in us-east-1 to us-east-2 prior to attempting the restore? Edit to clarify...
Converting to a draft PR while I investigate what looks like a related test failures ([testBackupHistory](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6294/2/testReport/org.apache.hadoop.hbase.backup/TestBackupShowHistory/testBackupHistory/)) Edit: I made a precondition too strict for the variety of paths that might...
> No, my testcase was "can a fresh HBase cluster restore a backup". 👍 > fresh cluster won't have any record stored of where backups were previously stored. So why...
Good idea, I don't obviously see a reason to persist the root on the BackupImage either, and any subtraction in this code is a big addition imo. I'll take a...
@DieterDP-ng I've thought about it a little bit more, and I'm less sure about taking the path out of the BackupManifest. I like that the backups can be used, even...
Yeah you're right, there wouldn't be a regression in usability — not sure I can even articulate my half-baked thought process from yesterday. Never mind