Ryan McCue

Results 402 comments of Ryan McCue

> Unable to get property 'push' of undefined or null reference > File: flatdoc.js, Line: 16, Column: 1904

With route documentation, should we use the URLs themselves instead? What's the best way to format our sidebar navigation? Example from [WooCommerce's docs](http://woothemes.github.io/woocommerce/rest-api/): ![screenshot 2014-05-29 11 16 11](https://cloud.githubusercontent.com/assets/21655/3113035/d73e7fac-e6ce-11e3-9ab7-34225a24e202.png) Counter-example from...

307 is basically a replacement for 302, so it should be appropriate in all cases anyway, but the wording probably could be clearer.

We should probably also display in the UI if a redirect won't be handled because the URL doesn't validate.

IMO, we should disable the domain validation entirely.

I don't think there's a huge security concern, IMO. `wp_validate_redirect` (and its counterpart, `wp_safe_redirect`) are specifically for the places in WP where [open redirects](https://owasp.org/www-project-cheat-sheets/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html) exist. `wp-login.php` for example takes a...

In my experience of using it so far, I get tripped up every time it doesn't actually redirect. I'm going to remove the use of `wp_validate_redirect` per above, as it's...

Should this be optional? 🤔 Trying to think of cases where you might want to *not* pass params through.

Notably, those aren't redirects, those are just straight up responses; I'd say it's out of scope for this plugin generally

If anyone's interested in maintaining the repo, I'm happy to transfer it from humanmade to a new owner :)