Ryan McCue comments

Results 402 comments of


                                            Ryan McCue

The ssh option doesn't accept a docker scheme when used in the root of a config file

Dug into this briefly; this occurs because wp-cli inside the container is using the same config file, so it tries to again execute `docker ...` _inside_ the container too. wp-cli...

Catch orphaned "running" jobs from MIA workers

See https://github.com/humanmade/Cavalcade-Runner/issues/75 for a solution for system shutdown, where we will pass SIGTERM to the workers and SIGKILL if they fail to respond.

Update to WPCS v3

Assuming just the major version bump and any BC breaks as a result

Compatibility with Cloudflare R2

As we don't use Cloudflare R2, we don't plan to add any specific support for this to S3 Uploads per [our support policy](https://engineering.hmn.md/projects/support/). We would accept documentation PRs (e.g. to...

Installed 3.0.4 manual-install.zip: wp-cli crashed: Callable "S3_Uploads\\WP_CLI_Command" does not exist, and cannot be registered as `wp s3-uploads`.

Thanks for the issue! We're going to remove this installation method to avoid problems like this, see #644.

Collision between Guzzle and various other plugins that all use their own composer layers

Closing as we're going to require installation via Composer (#644), which will handle dependency resolution.

Private uploads signed URLs access denied

Sounds like this might be the solution then; I'll close this out.

fix: always require autoload.php

Thanks for the PR! We're going to close this in favour of #644.

Error when uploading an attachment

@joemcgill This should be fixed now?

Component URLs that contain a slash are broken

Alternatively, we could change the router to `/:component+` I think and keep it working. `/components/Bootstrap%2FLoad` is a bit ugly.