Ryan McCue
Ryan McCue
Step 2 (selecting users) clearly stands out to me as being a bit out-of-place right now; see #28 for potential improvements over there.
Looks good! This does cause extra sets on the `$this->exists` array though, any thoughts on the performance of that with lots of posts?
Specifically, if I call `post_exists` twice with the same data, the second one will set the same key on the array again. The array we're talking about is potentially massive,...
Also, in keeping with the new naming scheme, this should be `wxr_importer.post_exists` instead.
> Why are you using . in your filter names? Because it looks nice. :) > The wp_import_existing_post name is specifically for compatibility with the existing WordPress Importer plugin form...
> I'll add a note that I've been bitten also by this when using hierarchical post types no longer matching parent/child posts. This should be handled already. It seems like...
One thing I want to do (#3) is enable other methods of importing attachments. Often, you'll have the files already, and want to dump them into place; or, you may...
> why should we re-download any attachment file if it already exists in the filesystem? Potentially the file may have been updated on the site we're importing from. It's rare,...
@swissspidy Permissions may be bothersome. You can't know the permissions of a post type until it's registered.
If you import an unknown post type without an author, it will assign that to the current user. If the post type is later registered, you may not have permission...