react-new-window icon indicating copy to clipboard operation
react-new-window copied to clipboard

Add new props of scripts and metas

Open shiyouping opened this issue 5 years ago • 1 comments

I added two new props that will generate script tags and meta tags. As I am not familiar with typescript, I am not sure if my modification to NewWindow.d.ts is correct or not. If not, please help me to correct it if you want to merge my changes. Many thanks.

shiyouping avatar Mar 07 '19 05:03 shiyouping

@shiyouping I'm wondering if it would be better to delegate the inclusion of metas, scripts and other stuff to the consumer instead of this lib. We could consider adding a callback that return the window reference. With that ref we will allow other consumers to do whatever that please them with the opened window. wdyt?

Note: I'm aware on the time it took me to reply.

rmariuzzo avatar May 30 '19 03:05 rmariuzzo