react-new-window icon indicating copy to clipboard operation
react-new-window copied to clipboard

Add checks because effects fire twice in dev for React 18

Open nmathew98 opened this issue 3 years ago • 1 comments

Issue: #130

Only call openChild if window is not set and only call componentWillUnmount when mounted state is true

Also remove @private modifier before import statements

@rmariuzzo

nmathew98 avatar Oct 16 '22 07:10 nmathew98

Will review by the EOD.

Quick update: I took a 5-days vacation. My health is average. I'm planning to add more collaborator to ensure continuous maintenance of this library.

rmariuzzo avatar Oct 16 '22 12:10 rmariuzzo

Thank you @nmathew98

rmariuzzo avatar Nov 26 '22 16:11 rmariuzzo