Laravel-JS-Localization icon indicating copy to clipboard operation
Laravel-JS-Localization copied to clipboard

Fix path issues in v1.9.1

Open SanderSander opened this issue 3 years ago • 8 comments

Fixes for the paths in v1.9.1

SanderSander avatar Aug 26 '22 12:08 SanderSander

I updated the PR because of the prev commit was reverted (This PR includes those changes).

BTW, I think the original commit adds a feature, so instead releasing it as 1.9.1 a patch version, maybe consider to release it as a minor version 1.10.0

SanderSander avatar Aug 26 '22 13:08 SanderSander

Any news guys? I'm on Laravel 9 and I had to change the file directly to support the /lang folder instead of /resources/lang

BaloccoDev avatar Oct 13 '22 10:10 BaloccoDev

I apologize for the slow response. Will chech that today.

rmariuzzo avatar Oct 14 '22 12:10 rmariuzzo

Hi @rmariuzzo, any idea when this fix will be released? This issue is still causing many headaches for people using Laravel 9, and Laravel 10 is around the corner...

jonaszkadziela avatar Jan 10 '23 15:01 jonaszkadziela

@jonaszkadziela I recall we fixed the issue the day it was discovered by reverting breaking changes; update your dependency to the newest version (1.9.0) and you should be good to go.

Chomiciak avatar Jan 10 '23 15:01 Chomiciak

@jonaszkadziela I recall we fixed the issue the day it was discovered by reverting breaking changes; update your dependency to the newest version (1.9.0) and you should be good to go.

Looking at the LaravelJsLocalizationServiceProvider class, it still does not locate files in the new default path which is project_root/lang: https://github.com/rmariuzzo/Laravel-JS-Localization/blob/v1.9.0/src/Mariuzzo/LaravelJsLocalization/LaravelJsLocalizationServiceProvider.php#L75

Therefore, any fresh Laravel 9.x application or existing project that uses the new path does not work with this package. Running php artisan lang:js -c command leads to the following exception: LaravelJsLocalization v1-9-0 - LangJsGenerator Exception

So, unfortunately, version 1.9.0 is not working. If this PR is merged, the issue should be resolved.

jonaszkadziela avatar Jan 11 '23 11:01 jonaszkadziela

I'm gonna take a look at this today, in a couple of hours.

rmariuzzo avatar Jan 11 '23 12:01 rmariuzzo

Guys, is this fix released?

thiagorsantoskpmg avatar Feb 10 '23 16:02 thiagorsantoskpmg