Lang.js icon indicating copy to clipboard operation
Lang.js copied to clipboard

Add messageFallback property

Open spyric opened this issue 7 years ago • 4 comments

This PR gives ability to notify application's owner about translation that is not exists in translation file.

spyric avatar May 08 '17 18:05 spyric

Any change to get this merged soon?

spyric avatar May 20 '17 13:05 spyric

Hey @spyric! I'm checking your proposal, is that a feature defined on Laravel's translator API ? The aim of this library is to provides API-compatible to laravel localization helper. :)

rmariuzzo avatar Jul 24 '17 17:07 rmariuzzo

Hello @rmariuzzo . In fact it's not.

But Laravel gives ability to register custom translator and handle missed translations. Currently there is no way to handle missed translations that occured in JS files, so I offered optional thing that will give ability to track it.

spyric avatar Jul 24 '17 18:07 spyric

Great! Let me think a little about it and comes to a conclusion. Thank you for replying.

On Jul 24, 2017 14:35, "Egor Talantsev" [email protected] wrote:

Hello @rmariuzzo https://github.com/rmariuzzo . In fact it's not.

But Laravel gives ability to register custom translator and handle missed translations. Currently there is no way to handle missed translations that occured in JS files, so I offered optional thing that will give ability to track it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rmariuzzo/Lang.js/pull/44#issuecomment-317514845, or mute the thread https://github.com/notifications/unsubscribe-auth/AAa2HydO7ru7SfKtsaZM7ymj5S7EdaiJks5sROP9gaJpZM4NUWmx .

rmariuzzo avatar Jul 25 '17 12:07 rmariuzzo