goto-preview icon indicating copy to clipboard operation
goto-preview copied to clipboard

[BUG] incorrect floating window closed in case multiple floating previews are opened

Open embe221ed opened this issue 2 years ago • 4 comments

Describe the bug I noticed that the change implemented in #115 made neovim close incorrect floating preview window. In case I have two floating windows open, :q will close the second one instead of the current floating window.

To Reproduce Steps to reproduce the behavior:

  1. go-to definition preview
  2. from the floating window open another definition preview
  3. try to close the newest floating window

Expected behavior the currently focused floating window is closed

Screenshots If applicable, add screenshots to help explain your problem.

Baseline (please complete the following information):

  • OS. e.g uname -a: MacOS
  • Neovim version nvim --version: NVIM v0.10.0-dev-2422+g0760d9868
  • URL to your current config (if public): https://github.com/embe221ed/scripts/tree/main/configs/nvim

embe221ed avatar Feb 22 '24 16:02 embe221ed

commenting out the code from #115 fixes the issue for me

embe221ed avatar Feb 22 '24 16:02 embe221ed

@Tebro have you experienced the issue above at all?

rmagatti avatar Feb 29 '24 18:02 rmagatti

I have not seen this, but I use <C-w>c to close windows. I however just tested using :q instead and I cannot reproduce.

Tebro avatar Feb 29 '24 19:02 Tebro

For the record, I can't reproduce this either. I'm on MacOS and Neovim built from master.

rmagatti avatar Mar 31 '24 05:03 rmagatti

Stale

rmagatti avatar Jul 16 '24 08:07 rmagatti