Unnecessary assignment at line 394?

[jtoly]

Is there something nuanced happening here?

VerifyStoreReceipt.m dictionaryWithAppStoreReceipt()

 // Attribute version
ASN1_get_object(&p, &length, &type, &xclass, seq_end - p);
if (type == V_ASN1_INTEGER && length == 1) {
    attr_version = p[0];
    attr_version = attr_version;
}

That second assignment on attr_version, to itself, after having just been assigned the value of p[0], is what I'm looking at.

[rmaddy]

That does seem pointless. That particular method was actually copied from another source. I never noticed that before. I can't see any problem removing that extra line.

BTW - please make sure you have the latest version of VerifyStoreReceipt.m. I just updated it a few minutes ago to fix a serious issue.

[jtoly]

Thank you. Will do. Do I close or pull or?