Ryan Macnak

Usage of SSE4 is quite old; the more recent change is snapshots in the SDK becoming AOT and deciding that using SSE4 is okay because the bot building the SDK...

Can reproduce with ``` import "package:expect/expect.dart"; class Foo { Foo(this.bar); Bar bar; } class Bar { int call(int x) => x * 2; } @pragma("vm:never-inline") int doCallThroughGetter(dynamic foo, int x)...

Hello_world and flutter_gallery build fine for me at this version. We would need either the program that failing to build to reproduce or the stack traces from the crash (e.g.,...

> target::kPageSize also should be renamed to target::kHeapPageSize No, kHeapPageSize refers to the size of a normal Dart heap chunk. Parts of the GC assume these chunks are also aligned...

A side benefit here might be that we can enable sharding on the Mac AOT bots. Sharding is disabled because XCode is only reliably installed on the main step, not...

The differences are in the PE/COFF timestamps and a GUID in the RSDS reference to the PDB file. It looks like ldd-link offers some flags to handle the COFF timestamp,...

cb59df7acfef63f1e124d9124c19c0d48ceed345

While the GC could do better here, I think this is mostly from uneven work distribution across the isolates. I noticed the timeline often had fewer open HandleMessage events than...

Manually symbolizing the first one: ``` 0x30d6d0 dart::MarkingVisitorBase::MarkingVisitorBase 0x30de80 dart::MarkingVisitorBase::MarkingVisitorBase 0x30d930 dart::MarkingVisitorBase::DrainMarkingStackWithPauseChecks 0x2e3b40 dart::ThreadPool::Worker::Main 0x2e3bf0 dart::ThreadPool::OnEnterIdleLocked 0x263ac0 dart::OSThread::CreateThreadLocal ```

Symbols might be a bit off, since DrainMarkingStackWithPauseChecks does not (even indirectly) call MarkingVisitorBase constructor.