vim-barbaric icon indicating copy to clipboard operation
vim-barbaric copied to clipboard

update xkbswitch-macosx README reference

Open xiehuc opened this issue 3 years ago • 2 comments

original xkbswitch-macosx's code is full of bug and hard to understand.

for eample:

  1. it use input source list index as an id, makes id differs on different machine
  2. it show layout by hard code it. just couldn't know why
  3. it couldn't set im.rime.inputmethod.Squirrel.Rime because it believes every sourceid has an com.apple prefix and hard code it.

so i modify it (copy from https://github.com/minoki/InputSourceSelector, change api, which earlier and better)

xiehuc avatar Jan 02 '22 04:01 xiehuc

Interesting! I can appreciate all the effort you put in to modify InputSourceSelector's API, but my preference would be to avoid forks wherever possible.

What would you think if we modified vim-barbaric to add support for InputSourceSelector as well as xkbswitch, and use whichever one it finds on the user's $PATH? We could add code to vim-barbaric to support InputSourceSelector's API directly instead of adding a dependency to your fork, which could incur some maintenance burden in the long run.

rlue avatar Jan 03 '22 01:01 rlue

you are right, i would do it when i have time.

i would also try pull request to original xkbswitch-macos to avoid fork

xiehuc avatar Jan 11 '22 08:01 xiehuc