Rémi Louf comments

Results 533 comments of


                                            Rémi Louf

RegexPrefixAllowedTokens does not work for batch

You are correct, this needs to be fixed.

RegexPrefixAllowedTokens does not work for batch

Thank you for considering contributing. I am not sure why this choice was made at the time, you'd have to ask @saattrupdan

RegexPrefixAllowedTokens does not work for batch

> @rlouf what are your thoughts on replacing `outlines/integrations/transformers.py` with a set of logits processors classes (similar to `outlines/integrations/llamacpp.py`) and updating `examples/transformers_integration.py` accordingly? Yes, this is where I was going...

Add multi-label conditional choice generation example

Of course, any contribution that improves the documentation is greatly appreciated!

Add multi-label conditional choice generation example

@davidberenstein1957 do you need help on this?

Add multi-label conditional choice generation example

Please share and I'll take a look!

Samplers don't implement Sampler Protocol

Thank you for pointing this out! What do you use for type checking?

Add continuous generation

This is cool, I really like the `continuous` function to a point I'd consider doing the same thing for `stream`. I'll review the PR soon, please bear with me.

Could not translate the instance {} to a regular expression

Thank you for opening an issue! Why do you need to remove the `format` property?

`outlines.generate.format(date)` allows model to produce invalid dates

We should indeed make sure that this cannot be generated. We might want to skip leap years for now though; according to [this StackOverflow post](https://stackoverflow.com/questions/15491894/regex-to-validate-date-formats-dd-mm-yyyy-dd-mm-yyyy-dd-mm-yyyy-dd-mmm-yyyy) a regex that takes leap...