Rémi Louf

Results 533 comments of Rémi Louf

I've been wondering if we should restrict the default pattern a little more to accept a maximum of 4 white spaces and one line break? That seems like a reasonable...

Fair. We can give it a try and see if we still get complaints from users.

Looks like we need to make sure `sequence_weights` and `logprobs` should be on the same device somewhere upstream.

Could you add a high-level description of what the PR does so the PR is self-contained? Is there an issue we could link to this PR? Also there is no...

I agree on fixing issues in `parsing.py` first.

Note that we should track both execution speed and memory usage.

Yes, it would have fixed it. Please update outlines to use the latest version and give it another try.