Rémi Louf
Rémi Louf
Thanks! We also need to figure out if the licenses are compatible and how to do proper attribution if you took inspiration from someone else's implementation. It looks like [Numpyro...
I rebased your branch on `main` to use the new key splitting scheme in the JAX backend. You'll have to pull the changes!
Yes you need to `git pull --rebase` in such cases. Here's [a good explanation of how rebasing works](https://git-scm.com/docs/git-rebase). And of course [the documentation for `git pull`](https://git-scm.com/docs/git-pull)
@GStechschulte I think we should follow @AdrienCorenflos's suggestion here. I'll take another look at it this week.
@GStechschulte I rebased your branch on `main`. Do you plan on implementing @AdrienCorenflos's suggestion above?
> @rlouf, I had to add a case for `Constant`s in `assert_size_argument_jax_compatible`. You'll need to confirm that this is valid more generally. That's valid. I was so focused on the...
Since some code probably relies on `true_div` we should: (1) Replace `true_div` with `true_divide` throughout the codebase (2) Create a `true_div` alias (3) Add a deprecation warning for those trying...
So that could eventually become a rewrite? And is that universally true for every backend who is that distinction tied to the C backend?
We should open issues for the remaining items.
> I guess you mean we might be missing an intermediate canonicalization form that is the same for either graph ~~Yes.~~ Then we can have `at.square(x)` be an alias for...