txWebSocket icon indicating copy to clipboard operation
txWebSocket copied to clipboard

don't delete the handler in loseConnection

Open wulczer opened this issue 14 years ago • 2 comments

if you call loseConnection on the WebSocketTransport it passes it on to the underlying Request, which then errbacks the notifications obtained with notifyFinish(), and WebSocketTransport then gets connectionLost on itself... and tries to call self._handler.connectionLost(), but the handler is already deleted.

I think you don't have to delete the handler in loseConnection, because connectionLost is going to be called anyway, so you can do it there.

wulczer avatar Feb 14 '11 12:02 wulczer

I have the same problem here. Please pull it :)

cnotin avatar Mar 01 '11 13:03 cnotin

here is my solution https://github.com/dervsh/txWebSocket/commit/3545c8d3c8aad2512a7fa06302da24989df6820a

dervsh avatar May 21 '11 09:05 dervsh