Natural
Natural copied to clipboard
rlogiacco
Next (v1.0.0-rc6)
This PR is still a work in progress, and represents an attempt at the 1.0 milestone release. The WIP flag will be removed once the feature set becomes stable.
TODO
- ~~test failures in cucumber parser~~
- ~~implement new formatting rules~~
- ~~Investigate other side effects in UI due to parser updates~~
@rlogiacco I'm sure I will spot something wrong 10 minutes after I write this, but I believe this is now ready for initial release canidate review. I will still like to spend a day using it on some real projects, but all automated tests are passing at the very least.
Cheers!
@rlogiacco FYI I tested the build on a fresh install and I noticed that eclipse would report some compile errors until I went to Windows -> Preferences -> Plugin Development -> Target Platform and select the project as the target.
Also, Tycho/Maven builds do not seem to be correctly initializing the Guice bindings prior to launching the ui tests, resulting in a failure when running mvn clean verify. I originally thought I had made a mistake configuring the bindings, but that doesn't seem to be the case as it also happens on a freshly generated Xtext project as well. I believe the pom.xml in the *.ui.tests bundles needs to be updated so Tycho can be pointed to the CucumberStandAloneSetup, or something of the sorts.
I have started a separate feature branch for step matcher updates, as I did not want to destabilize the release candidate.
~~Oops, I just spotted an issue. It seems like DocString is not getting its lexical highlighting applied. I added it to our full_example.feature~~.
Never mind, it was an easy fix.
@rlogiacco 6th time's a charm! haha. Sorry for all the rapid churn. I think we finally have a winner. Any user feedback prior to release would be greatly appreciated! I have only really tested my own personal workflows.
@rlogiacco I've posted a fix for failed lexical highlighting due to incorrect parsing of text literals in certain cases.
I also noticed that stepmatcher is being activated on non-java projects. I will need to post a patch for this as well I think, as it's pretty annoying getting all the unneeded warnings.
@rlogiacco The email I sent you was bounced. Is everything ok over there good friend?
Hi mate, I’m better, thanks. Are you ok? I got this weird “successor invite” on github and I thought something was going on on your side...
Il giorno mer 21 ott 2020 alle 02:08 Aaron R Miller < [email protected]> ha scritto:
@rlogiacco https://github.com/rlogiacco The email I sent you was bounced. Is everything ok over there good friend?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rlogiacco/Natural/pull/86#issuecomment-713210216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQWMLYXLWUYBXNYV62N53SLYRAZANCNFSM4PYFGEUQ .
Oh no haha, I just saw the option in the settings and you were the only one I could think of to put. I think it's some kind of "Bus Factor" protection. Good to hear from you, glad you are well!
I sent you an email from my new addresses but it bounced undeliverable. I wonder if it's because it's a new domain and I'm not in your contacts. Shoot off an email to [email protected] when you get a chance.
I may have a few more updates I can slip in here soon.
Email sent ;)
On Fri, Oct 23, 2020 at 4:30 AM Aaron R Miller [email protected] wrote:
Oh no haha, I just saw the option in the settings and you were the only one I could think of to put. I think it's some kind of "Bus Factor" protection. Good to hear from you, glad you are well!
I sent you an email from my new addresses but it bounced undeliverable. I wonder if it's because it's a new domain and I'm not in your contacts. Shoot off an email to [email protected] when you get a chance.
I may have a few more updates I can slip in here soon.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rlogiacco/Natural/pull/86#issuecomment-714868706, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQWMORUBQM4IIBN2D7F6TSMDTF5ANCNFSM4PYFGEUQ .