sinopia icon indicating copy to clipboard operation
sinopia copied to clipboard

support for newer versions of node.js

Open nreese opened this issue 8 years ago • 4 comments

When doing an npm install with newer versions of node.js (for example v4.2.1), npm returns lots of errors like

../node_modules/nan/nan.h:261:25: error: redefinition of '_NanEnsureLocal' NAN_INLINE v8::Local _NanEnsureLocal(v8::Local val) {

and

.node-gyp/4.2.1/include/node/v8.h:221:5: error: assigning to 'v8::Object *volatile' from incompatible type 'v8::Value *'

Any idea why newer versions of node.js choke on npm install? Are there any plans to update sinopia to support newer versions of node?

nreese avatar Apr 11 '16 18:04 nreese

I am using node 4.2.0 and works perfectly well. In my case Sinopia is running on a docker container

samithaf avatar Apr 12 '16 12:04 samithaf

@nreese is sinopia failing to install entirely, or are you just seeing these C errors?

If the latter, then I'm betting it's fs-ext, which is listed as an optionalDependency in sinopias package.json:

  "optionalDependencies": {
    "fs-ext": ">=0.4.1 <1.0.0-0",
    "crypt3": ">=0.1.6 <1.0.0-0"
  },

(https://github.com/rlidwka/sinopia/blob/master/package.yaml#L51-L55)

Which means there's likely a js fallback or maybe some kind of graceful degradation

davidmarkclements avatar Apr 12 '16 17:04 davidmarkclements

The issue I am seeing is closed with PR https://github.com/rlidwka/sinopia/pull/367. When will this be merged into the baseline?

Nathan

On Tue, Apr 12, 2016 at 11:56 AM, David Mark Clements < [email protected]> wrote:

@nreese https://github.com/nreese is sinopia failing to install entirely, or are you just seeing these C errors?

If the latter, then I'm betting it's fs-ext, which is listed as an optionalDependency in sinopias package.json:

"optionalDependencies": { "fs-ext": ">=0.4.1 <1.0.0-0", "crypt3": ">=0.1.6 <1.0.0-0" },

(https://github.com/rlidwka/sinopia/blob/master/package.yaml#L51-L55)

Which means there's likely a js fallback or maybe some kind of graceful degradation

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/rlidwka/sinopia/issues/393#issuecomment-209029438

nreese avatar Apr 12 '16 19:04 nreese

Some of us who depend on sinopia are working on continuing development as verdaccio:

https://github.com/verdaccio/verdaccio

As part of that, we are removing those optional dependencies. The C compiler will no longer be relevant, there won't be any nasty compiler warnings when installing, and it will improve multi-platform compatibility. npm and external Travis tests pass, too: travis badge

Verdaccio is not yet published to npm, but it will be soon. I just wanted to assure people that even though the original author may have abandoned it, it isn't the end of the line.

ghost avatar May 01 '16 10:05 ghost