uSkyBlock icon indicating copy to clipboard operation
uSkyBlock copied to clipboard

Can't detect ONLY source water blocks onIsland.

Open supertin opened this issue 9 years ago • 4 comments

Please paste the output from /usb version below

>usb version
[12:38:36 INFO]: Name: uSkyBlock
[12:38:36 INFO]: Version: 2.7.2
[12:38:36 INFO]: Description: Ultimate SkyBlock v2.7.2-45f756-430
[12:38:36 INFO]: Language: en (en)
[12:38:36 INFO]:   State: d=512, r=256, i=6, p=3, n=true, awe=true
[12:38:36 INFO]: Server: CraftBukkit git-Spigot-9797151-301db84 (MC: 1.10.2)
[12:38:36 INFO]:   State: online=true, bungee=false
[12:38:36 INFO]: ------------------------------
[12:38:36 INFO]: Vault 1.5.6-b49 (ENABLED)
[12:38:36 INFO]: WorldEdit 6.1.3;7a097ca (ENABLED)
[12:38:36 INFO]: WorldGuard 6.1.2;e38d98d (ENABLED)
[12:38:36 INFO]: FastAsyncWorldEdit 3.5.1-c52c1be (ENABLED)
[12:38:36 INFO]: Multiverse-Core 2.5-b719 (ENABLED)
[12:38:36 INFO]: Multiverse-Portals 2.5-b742 (ENABLED)
[12:38:36 INFO]: Multiverse-NetherPortals 2.5-b710 (ENABLED)
[12:38:36 INFO]: ------------------------------

What steps will reproduce the problem?

  1. Set a challenge to onIsland, detecting block "9:0:2". 9 is water, 9:0 is a source block, and 2 required.
  2. Put 1 water source (9:0) down in a place where it can flow out at least one block.
  3. Complete the challenge. Despite not having enough 9:0, it will complete anyway, as if the 0 is ignored.

It does work perfectly the other way around - challenges requiring 9:1 will only accept 9:1, not 9:0.

I'm not sure if water is the only effected block. It's possible Diorite/Granite might work as Stone in the same way (Stone is 1:0, Diorite is 1:3, etc).

supertin avatar Sep 22 '16 02:09 supertin

Interesting test. Will try to see if I can find the root-cause ;-)

rlf avatar Sep 22 '16 08:09 rlf

Not sure if I'm misunderstanding this, but if you're trying to match a source block vs flowing water, they have two separate IDs. Source block is "9" while flowing water is "8". So "9:1" should match one source block and "8:2:1" should match one flowing block with a level of 2.

BlackBeltPanda avatar Apr 16 '17 00:04 BlackBeltPanda

I thought that too. Turns out the "flowing" block is only used when moving into new areas after block updates. Once it flows out, the block switches back to a source block, but with a data value to set it's depth. You can test this with a single player world and MCEdit. Create a channel with "flowing" water, let it idle for a few seconds to finish reflowing the stream, then close the game and open in MCEdit. Check each block in the "flowing" stream, and you'll see they're actually source blocks.

supertin avatar Apr 16 '17 01:04 supertin

Wow, you're right. That's completely different from how I'd expect it to work, lol. GIF with IDs and data values: https://i.gyazo.com/be24473b26df64b0a9056870a4e8f1f7.gif

BlackBeltPanda avatar Apr 16 '17 01:04 BlackBeltPanda