rlarranaga

Hello @themillhousegroup, Understandable, thanks for the quick answer! What is pending for you to be able to land the binding in the main openHAB codebase? Do you need any help?...

If I wanted to start looking into merging, should clone this repository, run the maven recommendations from OH, and the do a pull request?

If have time, i will try to give it a go over the weekend. See how it goes. Would it be better to clone openhab-addons from the openhab repo (3.4)...

Hey, I ran `mvn clean install` against the current openhab-addons master. there were under 50 coding guideline errors. Most of them were easily fixable, having to do with headers, empty...

Just as an update, it looks like i managed to switch to Junit 5, and that cleared the 11 instances of the Junit package warning....only the 2 logger issues left.

According to this: https://github.com/pmd/pmd/issues/3860 The logger warnings are a false positive.....It looks like we might be ready. @themillhousegroup , how would you prefer to do the pull request? I cloned...

Hey, Are you sure the new branch is aligned with the current openhab-addons branch? there is bindings missing in it (i.e.: org.openhab.bindings.broadlinkthermostat) Thanks On Sun, Jul 10, 2022, 7:46 AM...

Disregard my previous comment. Pull request has been submitted. Re: Improvements, suggestions and request, lets hope there isn't many, and that since we are submitting into 3.4.0 Early in the...

Hey, Just let me know if I can help with anything else on this. Thanks

Hey @themillhousegroup Would you prefer me to try and merge this from my repo? Thanks