php-rrule icon indicating copy to clipboard operation
php-rrule copied to clipboard

Feature Suggestion: byeaster

Open meneken17 opened this issue 4 years ago • 2 comments

Hey, I am working on a project which requires christian hollidays. A lot of those are relative to easter sunday.

python-dateutil already supports this extension to the RFC:

byeaster If given, it must be either an integer, or a sequence of integers, positive or negative. Each integer will define an offset from the Easter Sunday. Passing the offset 0 to byeaster will yield the Easter Sunday itself. This is an extension to the RFC specification.

I could try to implemet it myself, but I do not yet understand your code well enough to do this.

meneken17 avatar Aug 01 '20 19:08 meneken17

Hello, thanks for the suggestion. When I did the port originally I was a bit reluctant to add non-standard extensions such as byeaster, since my intention was to be strict with RFC compliance. However maybe it's time to revisit this decision.

I will leave this ticket open for a bit to gauge if there are more people interested by this feature (please feel free to answer/react).

rlanvin avatar Aug 10 '20 12:08 rlanvin

Hey, thanks for the response. In my opinion this extension would not harm anybody: You can still parse every rfc conform rule and process it. You will still generare conform rules, unless the user decides to use the "byeaster". But to find this feature, he has to read some documentation (not just the rfc specs), which will state that the rule is not conform.

meneken17 avatar Aug 13 '20 21:08 meneken17