meetupr icon indicating copy to clipboard operation
meetupr copied to clipboard

Add GraphQL support

Open ledell opened this issue 2 years ago • 11 comments

Meetup will be deprecating the REST API and replacing it with GraphQL. The REST API will be deprecated at the end of 2021, and the GraphQL API is already active. Therefore, for this package to remain usable, we have to replace the guts. The ghql package could be useful.

Here’s the info on migrating from REST to GraphQL: https://www.meetup.com/api/migrating More info about GraphQL: https://www.meetup.com/api/general

FYI: @GregSutcliffe @maelle @benubah @LucyMcGowan @cvitolo @jennybc @Athanasiamo @olgamie @RickPack @malcolmbarrett @brooklynbagel @hfrick

ledell avatar Nov 10 '21 20:11 ledell

@GregSutcliffe @maelle @benubah @LucyMcGowan @cvitolo @jennybc @Athanasiamo @olgamie @RickPack @malcolmbarrett @brooklynbagel @hfrick

We scheduled a meeting to discuss this on Weds, Nov 17th at 11am PT. If any of you want to join, give a thumbs up and I will send you the invite.

ledell avatar Nov 12 '21 20:11 ledell

Its a little late for me in the evening, but keep me posted. I'd like to be involved as I rely on the pkg for the new website build.

drmowinckels avatar Nov 15 '21 06:11 drmowinckels

got the invite :+1:

hfrick avatar Nov 15 '21 10:11 hfrick

Update: @schloerke is currently working on rewriting the internal query logic and updating the two most useful functions, get_events() and find_groups().

ledell avatar Dec 28 '21 09:12 ledell

I can help with testing - let me know when.

jromanowska avatar Feb 20 '22 11:02 jromanowska

@jromanowska Thank you! @benubah Please let @jromanowska how she can help, when you're ready.

ledell avatar Feb 20 '22 20:02 ledell

Just to let everyone know... I am working on rewriting the remaining functions. I have working drafts but will send a PR soon so we can start testing.

benubah avatar Feb 21 '22 05:02 benubah

The work (plus testing) is ongoing here: https://github.com/rladies/meetupr/pull/138

benubah avatar Apr 04 '22 09:04 benubah

Thank you, @benubah!

RickPack avatar Apr 04 '22 10:04 RickPack

Great to see that this package is maintained and that the GraphQL support is being added! When can we expect the updates to be merged into the main branch?

frederikho avatar Apr 23 '22 12:04 frederikho

@frederikho I just merged into master. Please try it out if you can! We would really appreciate feedback. Thanks.

ledell avatar Apr 26 '22 07:04 ledell