docsis icon indicating copy to clipboard operation
docsis copied to clipboard

BitString can be decoded but not encoded

Open seimnseimn opened this issue 5 years ago • 4 comments

BitString can be decoded but not encoded

29:syntax error token BitString

(I can supply example binary if needed)

seimnseimn avatar Jun 17 '19 13:06 seimnseimn

An example would be good. Patches are better. This project isn’t really getting much attention. I’m giving it a home, but I don’t use it.

rlaager avatar Jun 17 '19 19:06 rlaager

Hi Richard,

to reproduce simply decode and encode below file. Unfortunately I'm not much of a c programmer. And it would take me quite some time to figure out how to patch this. On the other side I think this thing should have more stars as it is (to my knowledge) the only opensource and openly available docsis en-/decoder.

Have a nice day.

bits_test.cm.bin.zip

seimnseimn avatar Jun 18 '19 06:06 seimnseimn

I have a patch for this issue, how can I submit it?

spirit-t0aster avatar Oct 16 '19 21:10 spirit-t0aster

The best way would be a pull request. If you don’t know how to do a GitHub pull request, the gist is that you fork the repository, commit your changes on a branch, push that branch to your fork, and then it will give you a URL to create a pull request. If that sounds too complicated, you can paste the patch here.

rlaager avatar Oct 17 '19 03:10 rlaager