multi-vector-simulator icon indicating copy to clipboard operation
multi-vector-simulator copied to clipboard

[Bug] Degree of Autonomy KPI doesn't cope well with two energy providers

Open TheOneAndra opened this issue 4 years ago • 3 comments

In this system, two energy providers are used: Transmission system operator (energy vector: electricity) and Biogas (energy vector: electricity). This somehow causes an issue with the KPI degree of autonomy which is wrong.

Here is the folder to with the highlighted errors (in scalars) and the input: Error_DOA.zip

Checklist to make sure that the bug report ist complete:

  • [x] OS: windows, 10
  • [x] Branch: dev 0.5.5, updated on own local changes
  • [ ] If applicable: Attach full error message
  • [ ] If applicable: Share screenshots/images of your problem
  • [x] If applicable: Share used input data

TheOneAndra avatar Apr 15 '21 14:04 TheOneAndra

@smartie2076 Kindly suggested that this error might be solvable by adapting this and that part of the code

TheOneAndra avatar Apr 15 '21 14:04 TheOneAndra

Reasoning: Basically, we did not expect that two energy providers of the same energy carrier type would be used, and the values are overwritten. They should be added in line https://github.com/rl-institut/multi-vector-simulator/blob/dev/src/multi_vector_simulator/E3_indicator_calculation.py#L839

smartie2076 avatar Apr 15 '21 17:04 smartie2076

This would also be solved if we adopt the list of assets paradigm (like EPA) instead of dict of assets because you can add twice the same value in a list, but you can't have twice the same key in a dict. (reference to #689)

Bachibouzouk avatar Apr 16 '21 10:04 Bachibouzouk