multi-vector-simulator icon indicating copy to clipboard operation
multi-vector-simulator copied to clipboard

[Bug] ZeroDivisionError if no lifetime is provided in fixcosts.csv

Open Piranias opened this issue 4 years ago • 2 comments

If no fixcosts are used, there appears an error message (zero devision error) because the lifetime in fixcosts.csv is zero. This way the user has to change the lifetime to some value, even though the fixcosts are not defined afterall. Maybe at least a warning should be returned.

Error message: Fehlermeldung

and the input file were the error appears: fixcosts

Checklist to make sure that the bug report ist complete:

  • [x] OS: Ubuntu 20.04.2 LTS
  • [x] Branch: MVS 0.5.5
  • [x] If applicable: Attach full error message
  • [x] If applicable: Share screenshots/images of your problem
  • [x] If applicable: Share used input data

Piranias avatar Apr 06 '21 11:04 Piranias

Hi @Piranias! If you do not want to use fixcosts, you can simply delete all the columns, then you also don´t have to define anything.

The lifetime of any asset indeed always has to be > 0, but I checked and saw that this is not explained in the RTD, so that has to be fixed.

In general, input validation currently is not implemented, so there is no way for us to add default values.

smartie2076 avatar Apr 06 '21 13:04 smartie2076

ok sure. I just stumbled across this and thought others might have the same question. If it's mentioned in the rtd that should be fine

Piranias avatar Apr 06 '21 13:04 Piranias