multi-vector-simulator icon indicating copy to clipboard operation
multi-vector-simulator copied to clipboard

Incomplete description of storage*.csv

Open TheOneAndra opened this issue 5 years ago • 5 comments

It is not made clear in the doc how one should fill storage*.csv

Should the three columns be filled for all lines? Should input and ouput power be filled only for certain lines? Are they here just as a trick to specify the efficiency of the storage?

grafik

TheOneAndra avatar Dec 09 '20 14:12 TheOneAndra

Hm, actually it is described in the parameters section: soc max, soc min, soc initial, c-rate.

Would that be enough to fill it in for you? Do you have a proposal to make this better? If it is clear now, maybe you can create a small PR with a fix for the RTD.

smartie2076 avatar Dec 10 '20 16:12 smartie2076

@TheOneAndra do you have comments on this?

smartie2076 avatar Mar 02 '21 10:03 smartie2076

@TheOneAndra do you have comments on this?

Is this still valuable? Since the end user would use the GUI and not the csv files.

If you think it is still valuable, I will look at the RTD again (wich evolved a bit since this post) and see if I still find it could be clearer :)

TheOneAndra avatar Mar 02 '21 10:03 TheOneAndra

The end-user in terms of energy planners from real-life projects, yes, but researchers would still use the MVS as python code. So it would be valuable to improve the RTD for that!

smartie2076 avatar Mar 03 '21 13:03 smartie2076

I find the way the c-rate is presented in the example section is very clear. grafik

It would be good if the other parameters would be described similarly. soc_initial is missing: output power: NaN & (in Restrictions) The soc_initial has to be in [0,1]. soc_max is missing: input power: NaN & output power: NaN & (in Restrictions) The soc_max has to be in [0,1]. soc_min is missing: input power: NaN & output power: NaN & (in Restrictions) The soc_min has to be in [0,1].

These are very minor changes. Each parameter is described clearly enough as (most of) these details are curretnly in the Restrictions of each parameters. Nevertheless, If you like those changes, I can apply them in a mini PR.

TheOneAndra avatar Mar 05 '21 14:03 TheOneAndra