multi-vector-simulator icon indicating copy to clipboard operation
multi-vector-simulator copied to clipboard

C1: Update check_input_values and all_valid_intervals and use in C0

Open SabineHaas opened this issue 5 years ago • 4 comments

The function check_input_values is never used in MVS. Please check whether it should be used in C0 (see link!) or anywhere else.

SabineHaas avatar Mar 20 '20 08:03 SabineHaas

True, it is never used. That is also because it might need updating, eg. now we have these unit/value pairs that did not exist at that point. It could even be that the json tree is different from now...

We do need the module C1, though!

I am not sure when we should place this - one option would be right after reading the json input data, saving some time. I would prefer to place it right after pre-processing. because then we might be able to hint at busses that only have one connected asset, incomplete model branches, etc.

smartie2076 avatar Mar 20 '20 08:03 smartie2076

Are we still going I lost overview over the input data checks. @smartie2076 is this already tackled and if where could you add the link please?

SabineHaas avatar Jun 30 '20 15:06 SabineHaas

No, this is not tackled yet. @Bachibouzouk you also did not touch anything regarding default values for all parameters, did you?

smartie2076 avatar Jul 02 '20 08:07 smartie2076

you also did not touch anything regarding default values for all parameters, did you?

No I didn't do anything regarding default values of parameters

Bachibouzouk avatar Jul 02 '20 15:07 Bachibouzouk