Robert Kuykendall

Results 46 comments of Robert Kuykendall

@skidding Thank you for your response, I really appreciate it. That makes perfect sense. For those who don't care about IE11 but want to close these vulnerabilities (even though, as...

Going to close this as Felix answered it well. Re-open for further discussion.

@felixmosh I think I get this. The type error example here is `{ 'isLte': max }`, where max isn't a boolean or a string or a function, so it does...

https://github.com/kulshekhar/ts-jest/pull/308/files

I think this PR is a fix but I'm having trouble testing locally. I can confirm it passes tests locally. https://github.com/react-component/drawer/pull/404

I can confirm my fix is in. This issue can be closed.

Is there a logic around the separation between `onClose` and `onCancel`? The descriptions on Modal and Drawer are almost identical. It seems they should unify in a future major release...