pg_party icon indicating copy to clipboard operation
pg_party copied to clipboard

Added Rubocop config and GitHub Actions configuration

Open igor-alexandrov opened this issue 3 years ago • 5 comments

This PR partially covers #32 issue.

I added RuboCop configuration and GitHub Action (we can go with Circle if you want) to lint the code.

Rules that caused offenses and were fixed (with safe autocorrection):

  • Style/StringLiterals (Since there were both single quoted and double quoted strings, I decided to go with double quoted. This can be discussed)
  • Style/WordArray (Converted everything to %w[] notation)
  • Style/TrailingCommaInArguments
  • Style/PercentLiteralDelimiters
  • Style/NumericLiterals
  • Layout/HashAlignment
  • Layout/SpaceBeforeComma
  • Layout/SpaceBeforeBlockBraces
  • Layout/MultilineMethodCallIndentation

Also PR adds autogenerated .rubocop_todo.yml with offenses, that cannot be corrected automatically, they should be discussed individually.

Lets discuss.

igor-alexandrov avatar Dec 27 '22 10:12 igor-alexandrov

@rkrage wow, it seems I already started to work on GitHub Actions. I will update this PR.

igor-alexandrov avatar Oct 06 '23 18:10 igor-alexandrov

@rkrage this is ready to be merged.

I will add more Actions in a separate commit to transition from CircleCI.

igor-alexandrov avatar Oct 06 '23 19:10 igor-alexandrov

@igor-alexandrov can you rebase this and resolve the merge conflict?

rkrage avatar Oct 10 '23 22:10 rkrage