Rafal Korytkowski

Results 13 comments of Rafal Korytkowski

Please let me handle the merge and back-porting after reviews are done.

We need to revert this one. I'm sorry I haven't marked it as not yet ready for merging explicitly. I didn't mean it be merged before modules are adjusted. I'll...

Thanks for your pull request. Is there an issue related to this pull request under https://github.com/OpenConceptLab/oclapi/issues (I couldn't find one)? Please create one and say what is your goal here...

Thanks @dotasek for reviewing. I'll add tests. I'll keep the sessionId then.

I reworked the implementation. It no longer requires sessionId since the ValidationEngine is thread safe as per https://github.com/hapifhir/org.hl7.fhir.core/blob/f2fe93a1d7dfe66d1c70a7ef4379ed511a81e1c7/org.hl7.fhir.validation/src/main/java/org/hl7/fhir/validation/ValidationEngine.java#L152 and can be reused for all requests. Added support for Content-Type header...

Draft PR at https://github.com/hapifhir/org.hl7.fhir.validator-wrapper/pull/167

Have you tested it locally? It is very likely that it won't work if you are not using https to access the web server, which is typical for localhost (development)...

Thanks @pidsonn for trying! Please try to contribute on an easier issue next time to get more experience with the project. This is still not yet ready with a number...

Thanks @IamMujuziMoses and I'm sorry for getting back to you after that long. I was away... Please let me know if you are able to work on it within the...

Thank you! I made a few minor adjustments, because I still saw some some Liquibase updates being chceked by core in startup logs. My follow up fixes are in https://github.com/rkorytkowski/openmrs-core/commit/8075bd62513ba1107c1ceccab79c2bd857362634...