SangBin Cho comments

Results 292 comments of


                                            SangBin Cho

[core] If there's working_dir, don't set _py_driver_sys_path.

Please make sure to change docstring to the consistent style!

[core] If there's working_dir, don't set _py_driver_sys_path.

lmk when it is mergeable!

[core] If there's working_dir, don't set _py_driver_sys_path.

premerge failure

[Core] ray.remote raises ValueError when used on torch IterableDataset

Btw, I am very comfortable merging this PR. I feel a bit hacky that we are monkey patching the method. The CI failure also makes me feel like this is...

[Core] ray.remote raises ValueError when used on torch IterableDataset

yes. I prefer to ask users to workaround than adding dogpatches unless the issue is widely exists (and critical). We've actually suffered from some dogpatches we made in the past...

[Core] "The actor died unexpectedly before finishing this task." with aws spot instances

Does it happen if you don't use spot instance?

[Core] "The actor died unexpectedly before finishing this task." with aws spot instances

Hmm isn't that just the actor died because spot instance is interrupted then?

Use subreaper to kill unowned subprocesses in raylet.

I will review this by today!

Use subreaper to kill unowned subprocesses in raylet.

btw to be more clear about feedback (not 100% sure if it is possible); - Keep everything (decouple or how we track child process' health) as it is. - Ignore...

Use subreaper to kill unowned subprocesses in raylet.

Btw, can we accelerate the progress of this PR as the branch cut is coming? We'd like to merge this by this week to meet 2/29