SangBin Cho

icon indicating a website link https://www.linkedin.com/in/sang-cho/ icon indicating an email [email protected]

icon company Member of Technical Staff, xAI icon location MTS @ xAI | Previously @anyscale | Senior committer @ray-project | Committer @vllm-project

Results 292 comments of SangBin Cho

[Core | Python3.10] Upgrade pytest and fix all tests.

cc @rickyyx @scv119 this is TODO for python 3.10

Add API latency and call counts metrics to dashboard APIs

Can you update the PR description?

Add API latency and call counts metrics to dashboard APIs

Lmk when tests pass + addressed comments!

[Bug] core_driver.log leaks when log_to_driver=False

Hmm actually I think this is an intended behavior. The file is open because we are writing cpp logs from driver core worker.

[Core] Backpressure of gRPC server never worked.

Hey @iycheng let's remove this? However, we definitely need backpresure for the stability, and this can be handled as a part of GCS scalability?

[RuntimeEnv] debug log level can not be set.

@WangTaoTheTonic do you have a plan to make a PR? Otherwise I can fix it

[core] Get IP Address of Actor

@scottsun94 it's on the list. Btw what's the use case of this feature? Are you using this data for scheduling, or is it purely observability purpose?

[core] Get IP Address of Actor

> @richardliaw explains the use case at the top. Is there more info/context? The description doesn't answer my question I think. It just says what he wants, but not the...

[core] Get IP Address of Actor

Btw, I think adding `get_data` is not a too bad idea. It's easier to find the API, and we'd like to avoid using the state API for things other than...

Error: failed to get os threadid

I also found the same error. https://github.com/ray-project/ray/issues/30566 But for our case, we run py-spy within a docker container, so I am not sure how we can debug this issue... any...