line_profiler icon indicating copy to clipboard operation
line_profiler copied to clipboard

Published 20 hours ago • verified publisher icon rkern

TST: Update test matrix

Open pllim opened this issue 5 years ago • 10 comments

It is chronically failing and Python 3.3 is rather old by now.

pllim avatar Mar 20 '19 15:03 pllim

I think it is also unsupported. Is someone able to review this PR?

jakirkham avatar May 31 '19 23:05 jakirkham

3.4 is EOL now too.

cclauss avatar Jul 12 '19 20:07 cclauss

Also see #162

cclauss avatar Jul 12 '19 20:07 cclauss

Hah, @cclauss , looks like we are duplicating each other. I just updated this PR too. Anyway, I'll let the maintainers decide. I was just trying to help on the side and not really involved with this project.

pllim avatar Jul 12 '19 20:07 pllim

Same. It was a dependency on a project so I jumped in to see what the real story was. If you want to cherrypick the 3.7 and 3.8-dev stuff out of #162 and put them into this PR then I will gladly close #162.

cclauss avatar Jul 12 '19 20:07 cclauss

@cclauss , I think in a way I already did, except that I am not allowing 3.7 to fail.

pllim avatar Jul 12 '19 20:07 pllim

p.s. Yikes, it just failed, so maybe I'll have to.

pllim avatar Jul 12 '19 20:07 pllim

The problem is that very few maintainers pay a lot of attention or merge PRs that have failing tests. ;-)

cclauss avatar Jul 12 '19 20:07 cclauss

#153 or similar is required to be compatible with Python 3.7.

cclauss avatar Jul 12 '19 20:07 cclauss

p.s. As far as your dependency tree is concerned, given that this PR has been open for 4 months, you might want to be in contact with the maintainers or maybe have someone from your company to volunteer to co-maintain this. Just a thought.

pllim avatar Jul 12 '19 20:07 pllim