grayscale-mode
grayscale-mode copied to clipboard
rkbhochalya
Doesn't work on macs with M1 chip
I have Macbook Air 2020 with M1 and this app simply doesn't work. It doesn't matter if I click on enable or use the provided keybinding.
This is a bummer. Do we know what's not working with the latest M1 Mac computers?
Hmm, looks like the non-public C++ API we are using in the app to toggle grayscale mode doesn't work on mac computers with M1 chip. I do not have a computer with M1 to test it atm.
I'm guessing this is the one? https://github.com/rkbhochalya/grayscale-mode/blob/master/GrayscaleMode/grayscale.h
Where did you find that private C++ API in the first place? Maybe we can go to the docs/code you looked at and see if they updated it to work with M1 chips.
Looks like @brettferdosi has done an amazing job reverse engineering the proper way to toggle grayscale mode, and can be found here https://github.com/brettferdosi/grayscale/blob/master/Sources/Bridge.h
Just tested it by installing his app and it worked nicely. So we might want to port over his code into this app so that grayscale-mode can run on the Apple M1 chip family. Won't have the time to do this myself but writing it here in hope that someone else can pick it up.
https://gist.github.com/danielpunkass/df0d72be11b8956f2ef4f4d52cce7a41 is a very simple solution.
