defects4j icon indicating copy to clipboard operation
defects4j copied to clipboard

Lang-6 is fixed with wrong patch

Open zeyugao opened this issue 5 months ago • 0 comments

The original issue: https://issues.apache.org/jira/browse/LANG-857

The original patch: https://github.com/apache/commons-lang/commit/52bcd9b8e82d4d1d287b0d75df1e161aff8c65ab

But after digging it for a while, and checking against with the current version of commons-lang, the original patch is reverted (https://github.com/apache/commons-lang/commit/ab1424015085472b2d3865668e370aec8a102331#diff-a52232956711fb9042d1101775d44638e95bb979e1c73af2bf48d72d7c41d39cL95) and fixed with another commit: https://github.com/apache/commons-lang/commit/ab1424015085472b2d3865668e370aec8a102331#diff-5a1a900485fdfb970dd171f94df72a0a5e98da858739304784aa8482c48e40feL183

The correct fix should be placed in the CsvEscaper: https://github.com/apache/commons-lang/commit/ab1424015085472b2d3865668e370aec8a102331#diff-5a1a900485fdfb970dd171f94df72a0a5e98da858739304784aa8482c48e40feL166-L190

zeyugao avatar Sep 25 '24 12:09 zeyugao