react-jsonschema-form icon indicating copy to clipboard operation
react-jsonschema-form copied to clipboard

feat: carbon design system theme

Open YuJianghao opened this issue 1 year ago • 2 comments

Reasons for making this change

Add Carbon Design System theme. Also see #3857.

I use this Theme too. So, I'm here and try to make a PR for that.

If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit

Checklist

  • [ ] I'm updating documentation
  • [ ] I'm adding or updating code
    • [ ] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [ ] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Additional Information

I build a site to preview the theme: rjsf playground with carbon

Dev TODOs

  • [x] It seems that RJSF's component should have specific CSS class names, which needs a check also in the carbon theme.
  • [x] Switch custom context to formContext or globalUISchema.
  • [x] Fix styles in style tags.
  • [x] More widgets.
  • [ ] Figure out how to compile Sass files and distribute them to CSS.
  • [ ] https://github.com/rjsf-team/react-jsonschema-form/issues/3918
  • [ ] Update Readme.
  • [ ] Update Tests.
  • [ ] Update minor Version.
  • [ ] Fix: Netlify CI failed with build with cache. Could not find a declaration file for module "@rjsf/utils"

YuJianghao avatar Sep 29 '23 11:09 YuJianghao

Maybe we need OneOfFieldTemplate and AnyOfFieldTemplate, it's better than override a MultiSchemaField in custom theme. Also a SchemaFieldTemplate.

YuJianghao avatar Oct 09 '23 11:10 YuJianghao

@YuJianghao How goes the work on this theme? You seemed to have stalled out. Do you need anything from us?

heath-freenome avatar Apr 05 '24 19:04 heath-freenome