react-jsonschema-form
react-jsonschema-form copied to clipboard
rjsf-team
Add mantine UI package
Reasons for making this change
I wanted to add another provider, which is Mantine to allow to use their components withing rjsf library.
If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).
If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit
Checklist
- [ ] I'm updating documentation
- [ ] I've checked the rendering of the Markdown text I've added
- [x] I'm adding or updating code
- [ ] I'm adding a new feature
- [ ] I've updated the playground with an example use of the feature
@pkalisiewicz Can you fix your build, then I will take a look at the PR
@pkalisiewicz Can you fix your build, then I will take a look at the PR
@heath-freenome
Sure, I'm just having an issue with symlinking.
How can I link to the package that isn't yet published?
Can I somehow get it published as a draft, should I link in the playground directly?
I have temporarily commented out code that is adding mantine in playground until, I'll find a solution:)
@pkalisiewicz Ah, yeah that is an issue with adding new themes. I'm wrapping up a new feature and will take a look at this PR by next Monday. Sorry for the delay
@pkalisiewicz it looks like there is a typescript issue with your build?
(typescript) Error: /home/runner/work/react-jsonschema-form/react-jsonschema-form/packages/mantine-ui/src/MantineProvider/MantineProvider.tsx(1,53): semantic error TS2307: Cannot find module '@mantine/core' or its corresponding type declarations.
@pkalisiewicz If you can fix the build issues and deal with the conflicts, I can release your changes as part of 5.8.0 and then in 5.8.1 we can enable mantine-ui in the playground
hey @heath-freenome I have updated my PR, locally everything builds fine. I hope it should now build on CI fine as well
@pkalisiewicz It looks like the build is still having the Typescript issue.
@heath-freenome Sorry about that, I just realized I didn't add mantine it to the devDependencies, and it was getting the node modules from the root locally, but on the instance, it couldn't. That's solved!
@pkalisiewicz It still isn't working with the same typescript issue.
@pkalisiewicz Have you figured out why the builds keep failing with a typescript issue?
Stumbled across this PR as I'd really like to use RJSF with Mantine in some of my company's projects!
I have a hunch that the error in the CI build is being caused by a versioning issue with Mantine. The devDependency calls for "@mantine/core": "^4.2.12".
semantic error TS2339: Property 'Wrapper' does not exist on type 'InputComponent'.
The input component docs for Mantine v5 and v6 both include Input.Wrapper. However, the docs for v4 show the InputWrapper component being imported separately rather than being a property of Input. Looks like breaking changes were made between v4 and v5.
I'd suspect that bumping the minimum required version of Mantine up to v5 for both peer and dev dependencies would resolve the TypeScript build issue. I'll test this out locally when I get a chance, but thought I'd note this here in case it's helpful!
I reproduced the TypeScript build error locally. Updating the minimum required version of Mantine to v5 resolves the issue and the build succeeds.
@pkalisiewicz Can you update the mantine version to v5 and try again?
@pkalisiewicz Can you update the mantine version to v5 and try again?
So sorry for the late response. I have been extremely busy in the last few weeks.
I have updated it now
@pkalisiewicz two things, first please revert any of the package-lock.json files that are not related to mantine-ui or the playground. Second, there seems to be an issue with imports for the playground that I've seen before. I'm not sure about the fix at this point.
@pkalisiewicz @dbsmck @nachiket-p We need someone to help get these changes over the line
hey @pkalisiewicz, any chance you'd do this soon or someone should handle the remaining issues?
I am developing Mantine theme based on Mantine v7. It came from my private project, so there might be some discrepancies to the original behaviors. I'm working for bringing them closer.
Though it can't be taken over this PR, due to incompatibility between react-frame-component in playground and Mantine v7, you can try it and also make a PR if someone fix the problem.
@pkalisiewicz thank you for your previous contribution!
https://github.com/AokiApp/rjsf-mantine-theme
@pkalisiewicz I hope you are ok, This PR is just waiting for you to finish it
I am developing Mantine theme based on Mantine v7. It came from my private project, so there might be some discrepancies to the original behaviors. I'm working for bringing them closer.
Though it can't be taken over this PR, due to incompatibility between
react-frame-componentin playground and Mantine v7, you can try it and also make a PR if someone fix the problem. @pkalisiewicz thank you for your previous contribution!https://github.com/AokiApp/rjsf-mantine-theme
Which version of react-frame-component would work in the playground for your theme as well as the others?
@heath-freenome None would work as long as it relies on iframes. Mantine v7 has removed the Emotion dependency as well as the function to change the container into iframe like this. Without the function, iframe's CSS encapsulation would break. I could not fix it with v7, so I decided to fork it and make my own playground that don't use iframes.