react-jsonschema-form icon indicating copy to clipboard operation
react-jsonschema-form copied to clipboard

feat: release docs on release and not CI

Open jacqueswho opened this issue 2 years ago • 5 comments

Reasons for making this change

fixes #2847

Checklist

  • [ ] I'm updating documentation
  • [ ] I'm adding or updating code
    • [ ] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [ ] I've updated the changelog with a description of the PR
  • [x] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

jacqueswho avatar May 09 '22 18:05 jacqueswho

@epicfaace I was thinking that. But this way if any needs to release the docs early they can without waiting for code changes. There could be a scenario when there might just be doc changes and no code changes. Then to wait for a release could be troublesome. What do you think? By allowing to call the action on request as an option

jacqueswho avatar May 10 '22 05:05 jacqueswho

@epicfaace I was thinking that. But this way if any needs to release the docs early they can without waiting for code changes. There could be a scenario when there might just be doc changes and no code changes. Then to wait for a release could be troublesome. What do you think? By allowing to call the action on request as an option

Makes sense! Can you add a section to https://react-jsonschema-form.readthedocs.io/en/latest/contributing/#documentation that describes how docs deploy work and how to trigger a manual deploy?

epicfaace avatar May 10 '22 12:05 epicfaace

@epicfaace I cant merge

jacqueswho avatar May 12 '22 15:05 jacqueswho

@jacqueswho looks like the docs workflows never reported in?

heath-freenome avatar Jul 29 '22 01:07 heath-freenome

@epicfaace Do you concur this is ready to merge?

heath-freenome avatar Jul 29 '22 15:07 heath-freenome

@jacqueswho We really need to get stable built. What is missing?

heath-freenome avatar Aug 29 '22 21:08 heath-freenome

Agree, this looks good to me.

epicfaace avatar Aug 30 '22 13:08 epicfaace