react-jsonschema-form icon indicating copy to clipboard operation
react-jsonschema-form copied to clipboard

feat: chakra-ui adds name prop to hidden

Open rodrigofuentes opened this issue 3 years ago • 5 comments

Reasons for making this change

To align with the rest of @rjsf/chakra-ui , have added a name prop to the hidden input. This is as such it could be used in tools such as Remix.

Checklist

  • [ ] I'm updating documentation
  • [x] I'm adding or updating code
    • [x] I've added and/or updated tests
    • [ ] I've updated docs if needed
    • [ ] I've updated the changelog with a description of the PR
  • [x] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

rodrigofuentes avatar Feb 15 '22 16:02 rodrigofuentes

https://github.com/rjsf-team/react-jsonschema-form/blob/master/packages/core/src/components/widgets/HiddenWidget.js

Yeah it does. Wasn't sure if it aligned with the rest of the project. Ideally, this is a core file change, and every theme not using it would also have to. It's more than just the input file change.

Right now only the antd and chakra versions of rjsf use the name prop.

rodrigofuentes avatar Feb 21 '22 13:02 rodrigofuentes

Yeah it does. Wasn't sure if it aligned with the rest of the project. Ideally, this is a core file change, and every theme not using it would also have to. It's more than just the input file change.

Yes, I'm good with doing this. Can you update the PR to do this?

epicfaace avatar Feb 21 '22 16:02 epicfaace

@rodrigofuentes Two things and I feel like we can merge this...

  1. Rebase to latest
  2. Update the CHANGELOG.md to describe this fix

heath-freenome avatar Mar 11 '22 17:03 heath-freenome

@rodrigofuentes I agree with @epicfaace, merely update the HiddenWidget.tsx in core, add a test and update the CHANGELOG.md and you are good to go

heath-freenome avatar Aug 29 '22 16:08 heath-freenome

@rodrigofuentes If you need any help on this, I am available to chat on the discord channel

heath-freenome avatar Sep 07 '22 16:09 heath-freenome

@rodrigofuentes closing this as I took a holistic approach and added name to all inputs that were missing them in all themes in v5 with #3145

heath-freenome avatar Sep 23 '22 22:09 heath-freenome