react-jsonschema-form
react-jsonschema-form copied to clipboard
feat: chakra-ui adds name prop to hidden
Reasons for making this change
To align with the rest of @rjsf/chakra-ui
, have added a name prop to the hidden input.
This is as such it could be used in tools such as Remix.
Checklist
- [ ] I'm updating documentation
- [ ] I've checked the rendering of the Markdown text I've added
- [x] I'm adding or updating code
- [x] I'm adding a new feature
- [ ] I've updated the playground with an example use of the feature
https://github.com/rjsf-team/react-jsonschema-form/blob/master/packages/core/src/components/widgets/HiddenWidget.js
Yeah it does. Wasn't sure if it aligned with the rest of the project. Ideally, this is a core file change, and every theme not using it would also have to. It's more than just the input file change.
Right now only the antd and chakra versions of rjsf use the name prop.
Yeah it does. Wasn't sure if it aligned with the rest of the project. Ideally, this is a core file change, and every theme not using it would also have to. It's more than just the input file change.
Yes, I'm good with doing this. Can you update the PR to do this?
@rodrigofuentes Two things and I feel like we can merge this...
- Rebase to latest
- Update the
CHANGELOG.md
to describe this fix
@rodrigofuentes I agree with @epicfaace, merely update the HiddenWidget.tsx
in core
, add a test and update the CHANGELOG.md
and you are good to go
@rodrigofuentes If you need any help on this, I am available to chat on the discord channel
@rodrigofuentes closing this as I took a holistic approach and added name
to all inputs that were missing them in all themes in v5 with #3145